projects
/
cascardo
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eef4aa6
)
leds: lp5521: Fix return value
author
Sachin Kamat
<sachin.kamat@linaro.org>
Tue, 20 Nov 2012 09:59:00 +0000
(
01:59
-0800)
committer
Bryan Wu
<cooloney@gmail.com>
Mon, 26 Nov 2012 22:43:54 +0000
(14:43 -0800)
Return the value obtained from i2c_smbus_read_byte_data() instead of
-EIO. Silences the following smatch warning:
drivers/leds/leds-lp5521.c:155 lp5521_read() info:
why not propagate 'ret' from i2c_smbus_read_byte_data() instead of -5?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
drivers/leds/leds-lp5521.c
patch
|
blob
|
history
diff --git
a/drivers/leds/leds-lp5521.c
b/drivers/leds/leds-lp5521.c
index
362e29e
..
8505afe
100644
(file)
--- a/
drivers/leds/leds-lp5521.c
+++ b/
drivers/leds/leds-lp5521.c
@@
-152,7
+152,7
@@
static int lp5521_read(struct i2c_client *client, u8 reg, u8 *buf)
ret = i2c_smbus_read_byte_data(client, reg);
if (ret < 0)
- return
-EIO
;
+ return
ret
;
*buf = ret;
return 0;