greybus: audio: Fix memory leak
authorVaibhav Agarwal <vaibhav.agarwal@linaro.org>
Mon, 23 May 2016 18:01:14 +0000 (23:31 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Mon, 23 May 2016 21:41:41 +0000 (14:41 -0700)
Topology data pointer was mistakenly set to NULL before freeing it. Fix
this.

Fixes: 64a86d9ba850 ("audio: Add module specific driver")
Signed-off-by: Vaibhav Agarwal <vaibhav.agarwal@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/audio_module.c

index 57d3b02..53e84f5 100644 (file)
@@ -368,8 +368,8 @@ static void gb_audio_disconnect(struct gb_bundle *bundle)
 
        gbaudio_unregister_module(gbmodule);
        gbaudio_tplg_release(gbmodule);
-       gbmodule->topology = NULL;
        kfree(gbmodule->topology);
+       gbmodule->topology = NULL;
        gb_connection_disable(gbmodule->mgmt_connection);
        list_for_each_entry_safe(dai, _dai, &gbmodule->data_list, list) {
                gb_connection_disable(dai->connection);