MMC: S3C24XX: Fix s3c2410_dma_request() return code check.
authorBen Dooks <ben-linux@fluff.org>
Mon, 30 Jun 2008 21:40:33 +0000 (22:40 +0100)
committerPierre Ossman <drzeus@drzeus.cx>
Tue, 15 Jul 2008 12:14:47 +0000 (14:14 +0200)
The driver should be checking for a negative error code from
s3c2410_dma_request(), not non-zero. Newer kernels now return
the DMA channel number that was allocated by the request.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
drivers/mmc/host/s3cmci.c

index aa9a8b4..8389107 100644 (file)
@@ -1215,7 +1215,7 @@ static int __devinit s3cmci_probe(struct platform_device *pdev, int is2440)
                s3c2410_gpio_cfgpin(host->pdata->gpio_wprotect,
                                    S3C2410_GPIO_INPUT);
 
-       if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL)) {
+       if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL) < 0) {
                dev_err(&pdev->dev, "unable to get DMA channel.\n");
                ret = -EBUSY;
                goto probe_free_irq_cd;