ASoC: cs35l33: Fix testing return value of devm_gpiod_get_optional
authorAxel Lin <axel.lin@ingics.com>
Thu, 30 Jun 2016 00:13:34 +0000 (08:13 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 1 Jul 2016 09:53:56 +0000 (11:53 +0200)
devm_gpiod_get_optional() returns NULL when the gpio is not assigned.
So the if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) test is always false.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l33.c

index d8b5fc3..689c359 100644 (file)
@@ -1176,11 +1176,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client,
        /* We could issue !RST or skip it based on AMP topology */
        cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev,
                        "reset-gpios", GPIOD_OUT_HIGH);
-
-       if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) {
-               dev_warn(&i2c_client->dev,
-                       "%s WARNING: No reset gpio assigned\n", __func__);
-       } else if (IS_ERR(cs35l33->reset_gpio)) {
+       if (IS_ERR(cs35l33->reset_gpio)) {
                dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n",
                        __func__);
                return PTR_ERR(cs35l33->reset_gpio);