gpio: pxa: checking IS_ERR() instead of NULL
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 5 Jan 2016 09:56:37 +0000 (12:56 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 5 Jan 2016 10:19:26 +0000 (11:19 +0100)
irq_domain_add_legacy() returns NULL on error, it doesn't return error
pointers.

Fixes: 384ca3c6a28d ('gpio: pxa: change the interrupt management')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-pxa.c

index c2d1a47..415852d 100644 (file)
@@ -646,8 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
        pchip->irqdomain = irq_domain_add_legacy(pdev->dev.of_node,
                                                 pxa_last_gpio + 1, irq_base,
                                                 0, &pxa_irq_domain_ops, pchip);
-       if (IS_ERR(pchip->irqdomain))
-               return PTR_ERR(pchip->irqdomain);
+       if (!pchip->irqdomain)
+               return -ENOMEM;
 
        irq0 = platform_get_irq_byname(pdev, "gpio0");
        irq1 = platform_get_irq_byname(pdev, "gpio1");