powerpc: missing checks of __get_user()/__put_user() return values
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Apr 2012 21:01:49 +0000 (17:01 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 22 May 2012 03:59:22 +0000 (23:59 -0400)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/powerpc/kernel/signal_32.c

index ac1f960..61f6aff 100644 (file)
@@ -204,10 +204,10 @@ static inline int get_old_sigaction(struct k_sigaction *new_ka,
 
        if (!access_ok(VERIFY_READ, act, sizeof(*act)) ||
                        __get_user(new_ka->sa.sa_handler, &act->sa_handler) ||
-                       __get_user(new_ka->sa.sa_restorer, &act->sa_restorer))
+                       __get_user(new_ka->sa.sa_restorer, &act->sa_restorer) ||
+                       __get_user(new_ka->sa.sa_flags, &act->sa_flags) ||
+                       __get_user(mask, &act->sa_mask))
                return -EFAULT;
-       __get_user(new_ka->sa.sa_flags, &act->sa_flags);
-       __get_user(mask, &act->sa_mask);
        siginitset(&new_ka->sa.sa_mask, mask);
        return 0;
 }