ACPI, PCI, irq: remove redundant check for null string pointer
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Jan 2016 10:57:11 +0000 (10:57 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Jan 2016 12:40:05 +0000 (13:40 +0100)
source is decleared as a 4 byte char array in struct acpi_pci_routing_table
so !prt->source is a redundant null string pointer check. Detected with
smatch:

drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
  non-NULL. 'prt->source'

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/pci_irq.c

index c933675..d30184c 100644 (file)
@@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry,
                quirk = &prt_quirks[i];
 
                /* All current quirks involve link devices, not GSIs */
-               if (!prt->source)
-                       continue;
-
                if (dmi_check_system(quirk->system) &&
                    entry->id.segment == quirk->segment &&
                    entry->id.bus == quirk->bus &&