leds: 88pm860x: Add missing of_node_put()
authorAxel Lin <axel.lin@ingics.com>
Sun, 27 Jan 2013 12:56:57 +0000 (04:56 -0800)
committerBryan Wu <cooloney@gmail.com>
Thu, 7 Feb 2013 00:00:43 +0000 (16:00 -0800)
of_find_node_by_name() returns a node pointer with refcount incremented, use
of_node_put() on it when done.

of_find_node_by_name() will call of_node_put() against from parameter,
thus we also need to call of_node_get(from) before calling
of_find_node_by_name().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
drivers/leds/leds-88pm860x.c

index 6be2edd..f5b9ea3 100644 (file)
@@ -128,8 +128,10 @@ static void pm860x_led_set(struct led_classdev *cdev,
 static int pm860x_led_dt_init(struct platform_device *pdev,
                              struct pm860x_led *data)
 {
-       struct device_node *nproot = pdev->dev.parent->of_node, *np;
+       struct device_node *nproot, *np;
        int iset = 0;
+
+       nproot = of_node_get(pdev->dev.parent->of_node);
        if (!nproot)
                return -ENODEV;
        nproot = of_find_node_by_name(nproot, "leds");
@@ -145,6 +147,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
                        break;
                }
        }
+       of_node_put(nproot);
        return 0;
 }
 #else