HID: wacom: Delete unnecessary checks before the function call "input_free_device"
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 9 Jul 2015 06:08:15 +0000 (08:08 +0200)
committerJiri Kosina <jkosina@suse.com>
Thu, 9 Jul 2015 12:28:14 +0000 (14:28 +0200)
The input_free_device() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_sys.c

index 4c0ffca..936ad77 100644 (file)
@@ -1149,12 +1149,9 @@ static void wacom_free_inputs(struct wacom *wacom)
 {
        struct wacom_wac *wacom_wac = &(wacom->wacom_wac);
 
-       if (wacom_wac->pen_input)
-               input_free_device(wacom_wac->pen_input);
-       if (wacom_wac->touch_input)
-               input_free_device(wacom_wac->touch_input);
-       if (wacom_wac->pad_input)
-               input_free_device(wacom_wac->pad_input);
+       input_free_device(wacom_wac->pen_input);
+       input_free_device(wacom_wac->touch_input);
+       input_free_device(wacom_wac->pad_input);
        wacom_wac->pen_input = NULL;
        wacom_wac->touch_input = NULL;
        wacom_wac->pad_input = NULL;