[media] rtl28xxu: do not refcount rtl2832_sdr module
authorAntti Palosaari <crope@iki.fi>
Wed, 17 Dec 2014 11:16:10 +0000 (08:16 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 3 Feb 2015 18:21:48 +0000 (16:21 -0200)
This driver, rtl28xxu, offers frontend service for rtl2832_sdr
module, thus we are producer and rtl2832_sdr module is consumer.
Due to that, reference counting should be done in way rtl2832_sdr
takes refrence to rtl28xxu. Remove wrong refcount.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/dvb-usb-v2/rtl28xxu.c

index f475018..27cf341 100644 (file)
@@ -1142,16 +1142,12 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap)
                pdata.v4l2_subdev = subdev;
 
                request_module("%s", "rtl2832_sdr");
-               pdev = platform_device_register_data(&priv->i2c_client_demod->dev,
+               pdev = platform_device_register_data(&d->intf->dev,
                                                     "rtl2832_sdr",
                                                     PLATFORM_DEVID_AUTO,
                                                     &pdata, sizeof(pdata));
                if (pdev == NULL || pdev->dev.driver == NULL)
                        break;
-               if (!try_module_get(pdev->dev.driver->owner)) {
-                       platform_device_unregister(pdev);
-                       break;
-               }
                priv->platform_device_sdr = pdev;
                break;
        default:
@@ -1175,10 +1171,8 @@ static int rtl2832u_tuner_detach(struct dvb_usb_adapter *adap)
 
        /* remove platform SDR */
        pdev = priv->platform_device_sdr;
-       if (pdev) {
-               module_put(pdev->dev.driver->owner);
+       if (pdev)
                platform_device_unregister(pdev);
-       }
 
        /* remove I2C tuner */
        client = priv->i2c_client_tuner;