drm/radeon: drop explicit pci D3/D0 setting for ATPX power control
authorAlex Deucher <alexander.deucher@amd.com>
Thu, 2 Jun 2016 13:31:59 +0000 (09:31 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 7 Jul 2016 18:51:10 +0000 (14:51 -0400)
The ATPX power control method does this for you.

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_drv.c

index 7ed2498..c01a7c6 100644 (file)
@@ -411,9 +411,7 @@ static int radeon_pmops_runtime_suspend(struct device *dev)
        pci_ignore_hotplug(pdev);
        if (radeon_is_atpx_hybrid())
                pci_set_power_state(pdev, PCI_D3cold);
-       else if (radeon_has_atpx_dgpu_power_cntl())
-               pci_set_power_state(pdev, PCI_D3cold);
-       else
+       else if (!radeon_has_atpx_dgpu_power_cntl())
                pci_set_power_state(pdev, PCI_D3hot);
        drm_dev->switch_power_state = DRM_SWITCH_POWER_DYNAMIC_OFF;
 
@@ -431,7 +429,9 @@ static int radeon_pmops_runtime_resume(struct device *dev)
 
        drm_dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
 
-       pci_set_power_state(pdev, PCI_D0);
+       if (radeon_is_atpx_hybrid() ||
+           !radeon_has_atpx_dgpu_power_cntl())
+               pci_set_power_state(pdev, PCI_D0);
        pci_restore_state(pdev);
        ret = pci_enable_device(pdev);
        if (ret)