ARM: OMAP: dma: Remove the erroneous freeing of platform data
authorRajendra Nayak <rnayak@ti.com>
Thu, 13 Jun 2013 14:17:11 +0000 (19:47 +0530)
committerTony Lindgren <tony@atomide.com>
Tue, 18 Jun 2013 07:09:57 +0000 (00:09 -0700)
Given p = pdev->dev.platform_data; and
      d = p->dma_attr;
the freeing of either one of these by the driver
seems just plain wrong.

Get rid of them in the .probe failure path as well as the
.remove.

Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/plat-omap/dma.c

index 8a71f75..4d463ca 100644 (file)
@@ -2111,8 +2111,6 @@ exit_dma_irq_fail:
        }
 
 exit_dma_lch_fail:
-       kfree(p);
-       kfree(d);
        kfree(dma_chan);
        return ret;
 }
@@ -2133,8 +2131,6 @@ static int omap_system_dma_remove(struct platform_device *pdev)
                        free_irq(dma_irq, (void *)(irq_rel + 1));
                }
        }
-       kfree(p);
-       kfree(d);
        kfree(dma_chan);
        return 0;
 }