regulator: da9063: Do not hardcode return values
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 18 Feb 2014 10:41:05 +0000 (16:11 +0530)
committerMark Brown <broonie@linaro.org>
Wed, 19 Feb 2014 16:31:47 +0000 (01:31 +0900)
Propagate the error values returned by the function instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/da9063-regulator.c

index f5d1ca9..3c65644 100644 (file)
@@ -363,7 +363,7 @@ static int da9063_set_suspend_voltage(struct regulator_dev *rdev, int uV)
 
        sel = regulator_map_voltage_linear(rdev, uV, uV);
        if (sel < 0)
-               return -EINVAL;
+               return sel;
 
        sel <<= ffs(rdev->desc->vsel_mask) - 1;
 
@@ -755,7 +755,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
        if (ret < 0) {
                dev_err(&pdev->dev,
                        "Error while reading BUCKs configuration\n");
-               return -EIO;
+               return ret;
        }
        bcores_merged = val & DA9063_BCORE_MERGE;
        bmem_bio_merged = val & DA9063_BUCK_MERGE;