scripts/tags.sh: fix DEFINE_HASHTABLE in emacs case
authorDirk Gouders <dirk@gouders.net>
Sat, 16 Aug 2014 05:56:58 +0000 (07:56 +0200)
committerMichal Marek <mmarek@suse.cz>
Tue, 19 Aug 2014 09:12:43 +0000 (11:12 +0200)
The emacs --regex for DEFINE_HASHTABLE produced a warning because of
an unmatched '\('.  Further, the whole entry did not work, because the
regex needs to match from the beginning of a line, including keywords
like 'static'.  Finally, '\w' should not be used, because it
stops at underscores which are often part of variable names in C,
resulting in wrong entries in the tags file.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
Inspired-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
scripts/tags.sh

index 0f61bd7..fd651f9 100755 (executable)
@@ -255,7 +255,7 @@ emacs()
        --regex='/_PE(\([^,)]*\).*/PEVENT_ERRNO__\1/'           \
        --regex='/PCI_OP_READ(\([a-z]*[a-z]\).*[1-4])/pci_bus_read_config_\1/' \
        --regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/'\
-       --regex='/DEFINE_HASHTABLE\((\w*)/\1/'
+       --regex='/[^#]*DEFINE_HASHTABLE(\([^,)]*\)/\1/'
 
        all_kconfigs | xargs $1 -a                              \
        --regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'