drm: sun4i: Rely on the default ->best_encoder() behavior
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Tue, 7 Jun 2016 11:48:07 +0000 (13:48 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 10 Jun 2016 15:24:44 +0000 (17:24 +0200)
All outputs have a 1:1 relationship between connectors and encoders
and the driver is relying on the atomic helpers: we can drop the custom
->best_encoder() implementations and let the core call
drm_atomic_helper_best_encoder() for us.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1465300095-16971-13-git-send-email-boris.brezillon@free-electrons.com
drivers/gpu/drm/sun4i/sun4i_rgb.c
drivers/gpu/drm/sun4i/sun4i_tv.c

index ab64948..442cfe2 100644 (file)
@@ -90,19 +90,9 @@ static int sun4i_rgb_mode_valid(struct drm_connector *connector,
        return MODE_OK;
 }
 
-static struct drm_encoder *
-sun4i_rgb_best_encoder(struct drm_connector *connector)
-{
-       struct sun4i_rgb *rgb =
-               drm_connector_to_sun4i_rgb(connector);
-
-       return &rgb->encoder;
-}
-
 static struct drm_connector_helper_funcs sun4i_rgb_con_helper_funcs = {
        .get_modes      = sun4i_rgb_get_modes,
        .mode_valid     = sun4i_rgb_mode_valid,
-       .best_encoder   = sun4i_rgb_best_encoder,
 };
 
 static enum drm_connector_status
index bc047f9..b841478 100644 (file)
@@ -526,18 +526,9 @@ static int sun4i_tv_comp_mode_valid(struct drm_connector *connector,
        return MODE_OK;
 }
 
-static struct drm_encoder *
-sun4i_tv_comp_best_encoder(struct drm_connector *connector)
-{
-       struct sun4i_tv *tv = drm_connector_to_sun4i_tv(connector);
-
-       return &tv->encoder;
-}
-
 static struct drm_connector_helper_funcs sun4i_tv_comp_connector_helper_funcs = {
        .get_modes      = sun4i_tv_comp_get_modes,
        .mode_valid     = sun4i_tv_comp_mode_valid,
-       .best_encoder   = sun4i_tv_comp_best_encoder,
 };
 
 static enum drm_connector_status