staging: dgnc: clean up the dgnc_get_modem_info()
authorDaeseok Youn <daeseok.youn@gmail.com>
Wed, 4 May 2016 05:13:48 +0000 (14:13 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 May 2016 12:10:03 +0000 (14:10 +0200)
the "ch" in dgnc_get_modem_info() was already checked before calling
this function and also if "ch" is not NULL, dgnc_get_mstat() returns
valid value so it doesn't need to check an error.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_tty.c

index 392d532..a505775 100644 (file)
@@ -2020,17 +2020,7 @@ static inline int dgnc_get_mstat(struct channel_t *ch)
 static int dgnc_get_modem_info(struct channel_t *ch,
                               unsigned int  __user *value)
 {
-       int result;
-
-       if (!ch || ch->magic != DGNC_CHANNEL_MAGIC)
-               return -ENXIO;
-
-       result = dgnc_get_mstat(ch);
-
-       if (result < 0)
-               return -ENXIO;
-
-       return put_user(result, value);
+       return put_user(dgnc_get_mstat(ch), value);
 }
 
 /*