blktrace: delete garbage for message trace
authorShaohua Li <shli@fb.com>
Tue, 10 May 2016 00:22:13 +0000 (17:22 -0700)
committerJens Axboe <axboe@fb.com>
Tue, 10 May 2016 14:41:34 +0000 (08:41 -0600)
commit f4a1d08ce65 introduces a regression. Originally for
BLK_TN_MESSAGE, we add message in trace and return. The commit ignores
the early return and add garbage info.

Signed-off-by: Shaohua Li <shli@fb.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
kernel/trace/blktrace.c

index f94e7a2..8ae9ea2 100644 (file)
@@ -1349,6 +1349,7 @@ static enum print_line_t print_one_line(struct trace_iterator *iter,
        if (t->action == BLK_TN_MESSAGE) {
                log_action(iter, long_act ? "message" : "m");
                blk_log_msg(s, iter->ent);
+               return trace_handle_return(s);
        }
 
        if (unlikely(what == 0 || what >= ARRAY_SIZE(what2act)))