power: bq2415x_charger: Delete unnecessary checks before the function call "of_node_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 6 Nov 2015 15:48:46 +0000 (16:48 +0100)
committerSebastian Reichel <sre@kernel.org>
Sat, 5 Dec 2015 01:04:03 +0000 (02:04 +0100)
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/bq2415x_charger.c

index 4afd768..27e8953 100644 (file)
@@ -1704,7 +1704,7 @@ error_4:
 error_3:
        bq2415x_power_supply_exit(bq);
 error_2:
-       if (bq && bq->notify_node)
+       if (bq)
                of_node_put(bq->notify_node);
        kfree(name);
 error_1:
@@ -1724,9 +1724,7 @@ static int bq2415x_remove(struct i2c_client *client)
        if (bq->nb.notifier_call)
                power_supply_unreg_notifier(&bq->nb);
 
-       if (bq->notify_node)
-               of_node_put(bq->notify_node);
-
+       of_node_put(bq->notify_node);
        bq2415x_sysfs_exit(bq);
        bq2415x_power_supply_exit(bq);