ixgbe: don't use magic size number to assign ptp_caps.name
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 26 Feb 2014 01:58:54 +0000 (17:58 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Feb 2014 20:54:51 +0000 (15:54 -0500)
Rather than using a magic size number, just use sizeof since that will
work and is more robust to future changes.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c

index 5184e2a..9e54fcc 100644 (file)
@@ -840,7 +840,9 @@ void ixgbe_ptp_init(struct ixgbe_adapter *adapter)
 
        switch (adapter->hw.mac.type) {
        case ixgbe_mac_X540:
-               snprintf(adapter->ptp_caps.name, 16, "%s", netdev->name);
+               snprintf(adapter->ptp_caps.name,
+                        sizeof(adapter->ptp_caps.name),
+                        "%s", netdev->name);
                adapter->ptp_caps.owner = THIS_MODULE;
                adapter->ptp_caps.max_adj = 250000000;
                adapter->ptp_caps.n_alarm = 0;
@@ -854,7 +856,9 @@ void ixgbe_ptp_init(struct ixgbe_adapter *adapter)
                adapter->ptp_caps.enable = ixgbe_ptp_enable;
                break;
        case ixgbe_mac_82599EB:
-               snprintf(adapter->ptp_caps.name, 16, "%s", netdev->name);
+               snprintf(adapter->ptp_caps.name,
+                        sizeof(adapter->ptp_caps.name),
+                        "%s", netdev->name);
                adapter->ptp_caps.owner = THIS_MODULE;
                adapter->ptp_caps.max_adj = 250000000;
                adapter->ptp_caps.n_alarm = 0;