brcmfmac: use kmemdup
authorMuhammad Falak R Wani <falakreyaz@gmail.com>
Thu, 19 May 2016 13:59:03 +0000 (19:29 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 14 Jun 2016 14:26:48 +0000 (17:26 +0300)
Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

index 87819b3..16271c2 100644 (file)
@@ -6714,11 +6714,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
                return NULL;
        }
 
-       ops = kzalloc(sizeof(*ops), GFP_KERNEL);
+       ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL);
        if (!ops)
                return NULL;
 
-       memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops));
        ifp = netdev_priv(ndev);
 #ifdef CONFIG_PM
        if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))