net: ipv4: fix sparse error in fib_good_nh()
authorEric Dumazet <edumazet@google.com>
Thu, 18 Aug 2016 17:19:34 +0000 (10:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 20 Aug 2016 00:07:30 +0000 (17:07 -0700)
Fixes following sparse errors :

net/ipv4/fib_semantics.c:1579:61: warning: incorrect type in argument 2
(different base types)
net/ipv4/fib_semantics.c:1579:61:    expected unsigned int [unsigned]
[usertype] key
net/ipv4/fib_semantics.c:1579:61:    got restricted __be32 const
[usertype] nh_gw

Fixes: a6db4494d218c ("net: ipv4: Consider failed nexthops in multipath routes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c

index 539fa26..8066ccc 100644 (file)
@@ -1576,7 +1576,8 @@ static bool fib_good_nh(const struct fib_nh *nh)
 
                rcu_read_lock_bh();
 
-               n = __ipv4_neigh_lookup_noref(nh->nh_dev, nh->nh_gw);
+               n = __ipv4_neigh_lookup_noref(nh->nh_dev,
+                                             (__force u32)nh->nh_gw);
                if (n)
                        state = n->nud_state;