fbdev: omap2: panel-dpi: simplify gpio setting
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 10 Dec 2015 13:11:44 +0000 (14:11 +0100)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 29 Dec 2015 09:06:31 +0000 (11:06 +0200)
gpiod_set_value_cansleep is a noop when the passed descriptor is NULL.
So there is no need to duplicate the check for NULL; just call the
function unconditionally instead.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/omap2/displays-new/panel-dpi.c

index 06b6e61..e780fd4 100644 (file)
@@ -83,8 +83,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
        if (r)
                return r;
 
-       if (ddata->enable_gpio)
-               gpiod_set_value_cansleep(ddata->enable_gpio, 1);
+       gpiod_set_value_cansleep(ddata->enable_gpio, 1);
 
        if (gpio_is_valid(ddata->backlight_gpio))
                gpio_set_value_cansleep(ddata->backlight_gpio, 1);
@@ -105,8 +104,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
        if (gpio_is_valid(ddata->backlight_gpio))
                gpio_set_value_cansleep(ddata->backlight_gpio, 0);
 
-       if (ddata->enable_gpio)
-               gpiod_set_value_cansleep(ddata->enable_gpio, 0);
+       gpiod_set_value_cansleep(ddata->enable_gpio, 0);
 
        in->ops.dpi->disable(in);