net: pktgen: Deletion of an unnecessary check before the function call "proc_remove"

The proc_remove() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 443256b..da934fc 100644 (file)
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3728,8 +3728,7 @@ static int pktgen_remove_device(struct pktgen_thread *t,
        /* Remove proc before if_list entry, because add_device uses
         * list to determine if interface already exist, avoid race
         * with proc_create_data() */
-       if (pkt_dev->entry)
-               proc_remove(pkt_dev->entry);
+       proc_remove(pkt_dev->entry);
 
        /* And update the thread if_list */
        _rem_dev_from_if_list(t, pkt_dev);