serial: tegra: clean up tty-flag assignments
authorJohan Hovold <johan@kernel.org>
Tue, 18 Nov 2014 10:18:02 +0000 (11:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2014 01:06:39 +0000 (17:06 -0800)
The tty break and error flags are not bit masks so do not to use bitwise
OR when assigning them.

Note that there is no functional change due to the if-else construct and
flag having been initialised to zero (TTY_NORMAL).

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial-tegra.c

index 78a5cf6..48e6e41 100644 (file)
@@ -319,16 +319,16 @@ static char tegra_uart_decode_rx_error(struct tegra_uart_port *tup,
        if (unlikely(lsr & TEGRA_UART_LSR_ANY)) {
                if (lsr & UART_LSR_OE) {
                        /* Overrrun error */
-                       flag |= TTY_OVERRUN;
+                       flag = TTY_OVERRUN;
                        tup->uport.icount.overrun++;
                        dev_err(tup->uport.dev, "Got overrun errors\n");
                } else if (lsr & UART_LSR_PE) {
                        /* Parity error */
-                       flag |= TTY_PARITY;
+                       flag = TTY_PARITY;
                        tup->uport.icount.parity++;
                        dev_err(tup->uport.dev, "Got Parity errors\n");
                } else if (lsr & UART_LSR_FE) {
-                       flag |= TTY_FRAME;
+                       flag = TTY_FRAME;
                        tup->uport.icount.frame++;
                        dev_err(tup->uport.dev, "Got frame errors\n");
                } else if (lsr & UART_LSR_BI) {