From: Devendra Naga Date: Thu, 12 Jul 2012 06:12:25 +0000 (+0545) Subject: UPSTREAM: staging/gdm72xx: cleanup little at gdm_wimax_event_rcv X-Git-Url: http://git.cascardo.eti.br/?a=commitdiff_plain;h=463d5fab1fb5af9f4a57e7214e39d6ab21c226e8;p=cascardo%2Flinux.git UPSTREAM: staging/gdm72xx: cleanup little at gdm_wimax_event_rcv the event sock check is done at the netlink_init itself. Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman (cherry picked from commit 8df858ea76b76dde9a39d4edd9aaded983582cfe) Change-Id: I8ef8a42bdd6ac462211344371174a20d28b049a9 Reviewed-on: https://gerrit.chromium.org/gerrit/30132 Reviewed-by: Olof Johansson Commit-Ready: Ben Chan Tested-by: Ben Chan --- diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index e616de13b623..0716efc1817d 100644 --- a/drivers/staging/gdm72xx/gdm_wimax.c +++ b/drivers/staging/gdm72xx/gdm_wimax.c @@ -255,17 +255,15 @@ static void gdm_wimax_event_rcv(struct net_device *dev, u16 type, void *msg, static int gdm_wimax_event_init(void) { - if (wm_event.ref_cnt == 0) { + if (!wm_event.ref_cnt) { wm_event.sock = netlink_init(NETLINK_WIMAX, gdm_wimax_event_rcv); + if (wm_event.sock) + wm_event.ref_cnt++; INIT_LIST_HEAD(&wm_event.evtq); INIT_LIST_HEAD(&wm_event.freeq); INIT_WORK(&wm_event.ws, __gdm_wimax_event_send); spin_lock_init(&wm_event.evt_lock); - } - - if (wm_event.sock) { - wm_event.ref_cnt++; return 0; }