From: Nicolai Stange <nicstange@gmail.com>
Date: Tue, 22 Mar 2016 12:12:45 +0000 (+0100)
Subject: lib/mpi: mpi_read_raw_from_sgl(): purge redundant clearing of nbits
X-Git-Tag: v4.7-rc1~106^2~54
X-Git-Url: http://git.cascardo.eti.br/?a=commitdiff_plain;h=60e1b74c224e9eda14e5b479413c5d990373c2cb;p=cascardo%2Flinux.git

lib/mpi: mpi_read_raw_from_sgl(): purge redundant clearing of nbits

In mpi_read_raw_from_sgl(), unsigned nbits is calculated as follows:

  nbits = nbytes * 8;

and redundantly cleared later on if nbytes == 0:

  if (nbytes > 0)
    ...
  else
    nbits = 0;

Purge this redundant clearing for the sake of clarity.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index 4ba0f2361d3c..27703aad287a 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -461,8 +461,6 @@ MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int nbytes)
 
 	if (nbytes > 0)
 		nbits -= count_leading_zeros(*(u8 *)(sg_virt(sgl) + lzeros));
-	else
-		nbits = 0;
 
 	nlimbs = DIV_ROUND_UP(nbytes, BYTES_PER_MPI_LIMB);
 	val = mpi_alloc(nlimbs);