From: Vincent Palatin Date: Thu, 2 Aug 2012 22:32:49 +0000 (+0000) Subject: rtc: recycle id when unloading a rtc driver X-Git-Url: http://git.cascardo.eti.br/?a=commitdiff_plain;h=babae92201715e17bfd0aabcb4b2834e116221b7;p=cascardo%2Flinux.git rtc: recycle id when unloading a rtc driver When calling rtc_device_unregister, we are not freeing the id used by the driver. So when doing a unload/load cycle for a RTC driver (e.g. rmmod rtc_cmos && modprobe rtc_cmos), its id is incremented by one. As a consequence, we no longer have neither an rtc0 driver nor a /proc/driver/rtc (as it only exists for the first driver). Signed-off-by: Vincent Palatin BUG=None TEST=on x86 platform, rmmod rtc_cmos && modprobe rtc_cmos and see the new rtc driver is still /sys/class/rtc/rtc0 and /proc/driver/rtc still exists. Change-Id: I1b60e25611d30b46a3744d38dc34213db6e21b72 Reviewed-on: https://gerrit.chromium.org/gerrit/29103 Reviewed-by: Derek Basehore Tested-by: Derek Basehore Tested-by: Vincent Palatin Reviewed-by: Olof Johansson Commit-Ready: Vincent Palatin --- diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index dc4c2748bbc3..37b1d82fda08 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -238,6 +238,7 @@ void rtc_device_unregister(struct rtc_device *rtc) rtc_proc_del_device(rtc); device_unregister(&rtc->dev); rtc->ops = NULL; + ida_simple_remove(&rtc_ida, rtc->id); mutex_unlock(&rtc->ops_lock); put_device(&rtc->dev); }