From: Alex Wang Date: Tue, 23 Jul 2013 01:15:49 +0000 (-0700) Subject: vlan-splinter: Fix inverted logic bug. X-Git-Tag: v1.10.2 X-Git-Url: http://git.cascardo.eti.br/?a=commitdiff_plain;h=refs%2Ftags%2Fv1.10.2;hp=39ee7080f059ba331672447ed48c0937f04e3a0f;p=cascardo%2Fovs.git vlan-splinter: Fix inverted logic bug. When "other-config:enable-vlan-splinters=true" is set, the existing vlans with ip address must be retained. The bug actually does the opposite and retains the vlans without ip address. This commit fixes it. Reported-by: Roman Sokolkov Signed-off-by: Alex Wang Signed-off-by: Ben Pfaff --- diff --git a/AUTHORS b/AUTHORS index 0cb1ac642..ce96e5dcd 100644 --- a/AUTHORS +++ b/AUTHORS @@ -181,6 +181,7 @@ Ramana Reddy gtvrreddy@gmail.com Rob Sherwood rob.sherwood@bigswitch.com Roger Leigh rleigh@codelibre.net Rogério Vinhal Nunes +Roman Sokolkov rsokolkov@gmail.com Saul St. John sstjohn@cs.wisc.edu Scott Hendricks shendricks@nicira.com Sean Brady sbrady@gtfservices.com diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 724b4b937..186bdd072 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -3974,10 +3974,10 @@ collect_splinter_vlans(const struct ovsrec_open_vswitch *ovs_cfg) if (!netdev_open(vlan_dev->name, "system", &netdev)) { if (!netdev_get_in4(netdev, NULL, NULL) || !netdev_get_in6(netdev, NULL)) { - vlandev_del(vlan_dev->name); - } else { /* It has an IP address configured, so we don't own * it. Don't delete it. */ + } else { + vlandev_del(vlan_dev->name); } netdev_close(netdev); }