Namrata A Shettar [Thu, 29 Sep 2016 16:37:39 +0000 (22:07 +0530)]
staging: rts5208: Replace explicit NULL comparison
Replace explicit NULL comparison to resolve checkpatch issues.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Namrata A Shettar [Thu, 29 Sep 2016 16:35:31 +0000 (22:05 +0530)]
staging: rts5208: Add space around binary operators
Add space around binary operators to resolve checkpatch issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Thu, 29 Sep 2016 15:22:00 +0000 (20:52 +0530)]
Staging: speakup: constify attribute_group structures
Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property can also be made constant.
Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
7551 1440 16 9007 232f
drivers/staging/speakup/kobjects.o
File size after:
text data bss dec hex filename
7671 1312 16 8999 2327
drivers/staging/speakup/kobjects.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:20 +0000 (20:20 +0200)]
staging: wlang-ng: Fix block comments style warnings in hfa384x.h
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: Block comments use * on subsequent lines
No more warnings block comments warnings for this file.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:19 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:18 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_metacmd_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:17 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usbctlxq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:16 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usbctlx_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:15 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_rridresult_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:14 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_cmdresult_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:13 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdrec_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:12 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_end_of_pda_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:11 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_manf_testi_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:10 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_manf_testsp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:09 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_hfo_delay_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:08 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_nic_config_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:07 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_chcali_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:06 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_chcalsp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:05 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_ifrf_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:04 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_shadow_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:03 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_hfa3861_baseline_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:02 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_rfr_setting_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:01 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_ifr_setting_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:20:00 +0000 (20:20 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_trimdac_setup_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:59 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_level_comp_setup_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:58 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_vgdac_setup_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:57 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_refdac_setup_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:56 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_temptype_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:55 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_privacy_option_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:54 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_default_channel_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:53 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_allowed_channel_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:52 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_regdomain_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:51 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_mkk_callname_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:50 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_mac_address_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:49 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_level_compc_measurements_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:48 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_vgdac_measurements_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:47 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_refdac_measurements_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:46 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_nicid_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:45 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_cfisuprange_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:44 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_mfisuprange_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:43 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_nic_ramsize_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:42 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_mkk_measurements_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:41 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_nic_serial_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:40 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_pcb_tracenum_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:39 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_pdr_pcb_partnum_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:38 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usbin_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usbin_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:37 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usbout_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usbout_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:36 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_error_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:35 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_bufavail_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:34 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_rmemresp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:33 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_wmemresp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:32 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_rridresp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:31 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_wridresp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:30 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_cmdresp_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:29 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_infofrm_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:28 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_rxfrm_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:27 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_rmemreq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:26 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_wmemreq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:25 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_rridreq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:24 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_wridreq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:23 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_cmdreq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:22 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usb_txfrm_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:21 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_InfFrame_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:20 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_infodata_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_infodata_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:19 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_KeyIDChanged_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:18 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_PSUserCount_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:17 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_AuthReq_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:16 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_AssocStatus_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:15 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_LinkStatus_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:14 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_HScanResult_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:13 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_HScanResultSub_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:12 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_ChInfoResult_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:11 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_ChInfoResultSub_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:10 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_ScanResult_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:09 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_ScanResultSub_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:08 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_CommTallies32_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:07 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_CommTallies16_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:06 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_rx_frame_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:05 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_tx_frame_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:04 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_dbmcommsquality_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:03 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_commsquality_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:02 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_downloadbuffer_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:01 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_WPAData_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:19:00 +0000 (20:19 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_authenticateStation_data_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:59 +0000 (20:18 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_JoinRequest_data_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:58 +0000 (20:18 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_HostScanRequest_data_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:57 +0000 (20:18 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_caplevel_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:56 +0000 (20:18 +0200)]
staging: wlang-ng: Fix block comments style warnings in hfa384x.h
This patch fixes the following checkpatch.pl warnings in hfa384x.h:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:55 +0000 (20:18 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_compident_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_compident_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Wed, 28 Sep 2016 18:18:54 +0000 (20:18 +0200)]
staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_bytestr32_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Fri, 30 Sep 2016 22:58:44 +0000 (22:58 +0000)]
staging: android: ion: fix checks found by checkpatch.pl
Alignment fixes
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Fri, 30 Sep 2016 23:12:55 +0000 (23:12 +0000)]
staging: android: ion: fix warning found by checkpatch.pl
Fix checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elizabeth Ferdman [Thu, 29 Sep 2016 22:45:55 +0000 (15:45 -0700)]
staging: media: replace unsigned with unsigned int
Fix checkpatch error "Prefer 'unsigned int' to bare use of 'unsigned'"
for readability.
Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Moshe Green [Sun, 2 Oct 2016 11:04:46 +0000 (14:04 +0300)]
staging: sm750fb: replace roundedDiv with DIV_ROUND_CLOSEST
Replace local implementation of rounded division (roundedDiv macro) with
the in-kernel implementation (DIV_ROUND_CLOSEST macro) in ddk750_chip.c
Signed-off-by: Moshe Green <mgmoshes@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elizabeth Ferdman [Wed, 28 Sep 2016 21:33:51 +0000 (14:33 -0700)]
staging: sm750fb: conform to block comment style
Fix 2 checkpatch errors:
-Block comments use * on subsequent lines,
-Block comments use a trailing */ on a separate line
to conform to block commenting style.
Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Miguel Silva [Fri, 30 Sep 2016 17:26:55 +0000 (18:26 +0100)]
staging: greybus: light: check the correct value of delay_on
When checking the value of delay_on to set the channel as active, it was
checked the pointer and not the value, as it should be.
Fixes:
cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP side")
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Greer [Wed, 28 Sep 2016 16:34:49 +0000 (09:34 -0700)]
staging: greybus: Add remaining audio files to maintained list
Some Greybus Audio Device Class Protocol driver files are missing
in the MAINTAINERS file even though they are maintained so add
them.
CC: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Signed-off-by: Mark Greer <mgreer@animalcreek.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Miguel Silva [Fri, 30 Sep 2016 18:24:33 +0000 (19:24 +0100)]
staging: greybus: light: check delay_{on|off} before use
Even though we trust leds core that the pointers should be valid, we are
safer to check delay_{on|off} before use.
Also, this avoid a smatch warning:
drivers/staging/greybus/light.c:484 gb_blink_set()
warn: variable dereferenced before check 'delay_on' (see line 476)
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Miguel Silva [Fri, 30 Sep 2016 18:24:32 +0000 (19:24 +0100)]
staging: greybus: light: fix attributes allocation
Fix allocation of attributes with the correct size, this also fix smatch
warning:
drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Miguel Silva [Fri, 30 Sep 2016 18:24:31 +0000 (19:24 +0100)]
staging: greybus: sdio: fix cmd_flags check for none response
When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.
smatch warn:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
warn: bitwise AND condition is false here
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / cascardo / linux.git / log