From dfd9e00ff07ebbf1c3e4d9ef525ba38e2e96739e Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 5 Oct 2014 13:33:16 -0400 Subject: [PATCH] Fix login session's userdata acquisition With the transaction code changes th session.login() function was incorrectly moved before all the userdata was gathered. An incomplete set was stored in the session. Signed-off-by: Simo Sorce Reviewed-by: Patrick Uiterwijk --- ipsilon/login/common.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ipsilon/login/common.py b/ipsilon/login/common.py index 2b3ac19..3f44c15 100755 --- a/ipsilon/login/common.py +++ b/ipsilon/login/common.py @@ -45,7 +45,6 @@ class LoginManagerBase(PluginObject, Log): def auth_successful(self, trans, username, auth_type=None, userdata=None): session = UserSession() - session.login(username, userdata) if self.info: userattrs = self.info.get_user_attrs(username) @@ -61,6 +60,9 @@ class LoginManagerBase(PluginObject, Log): else: userdata = {'auth_type': auth_type} + # create session login including all the userdata just gathered + session.login(username, userdata) + # save username into a cookie if parent was form base auth if auth_type == 'password': cookie = SecureCookie(USERNAME_COOKIE, username) -- 2.20.1