From 200cbaead5f0b58bd893e471cdd274a80a90fcfd Mon Sep 17 00:00:00 2001 From: Sean Paul Date: Fri, 7 Sep 2012 11:51:46 -0700 Subject: [PATCH] drm/exynos: fimd: Fix compilation warning This patch fixes a compilation warning (and possibly) use uninitialized in fimd_display_power_on by returning early if we received an invalid DPMS mode value. BUG=chrome-os-partner:13349 TEST=Tested on snow Change-Id: I30b8840c71d3f7239871836b184817fc23b25b7a Signed-off-by: Sean Paul Reviewed-on: https://gerrit.chromium.org/gerrit/32572 --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index d0811ac374fd..dda22018b1fa 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -156,7 +156,7 @@ static int fimd_display_power_on(struct device *dev, int mode) break; default: DRM_DEBUG_KMS("unspecified mode %d\n", mode); - break; + return -EINVAL; } fimd_power_on(ctx, enable); @@ -784,9 +784,6 @@ static int fimd_power_on(struct fimd_context *ctx, bool enable) DRM_DEBUG_KMS("%s\n", __FILE__); - if (enable != false && enable != true) - return -EINVAL; - if (enable) { int ret; -- 2.20.1