From 21b83c6d6035828dce80774746d9a5b0e50d0981 Mon Sep 17 00:00:00 2001 From: Sorin Vinturis Date: Tue, 18 Nov 2014 14:20:39 +0000 Subject: [PATCH] datapath-windows: Removed duplicate checking of previous dump state Removed the check for previous dump state before calling FreeUserDumpState as the check is also performed in the latter function. Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju Signed-off-by: Ben Pfaff --- datapath-windows/ovsext/Datapath.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 49a0b68e6..ce56e3266 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -783,7 +783,7 @@ OvsDeviceControl(PDEVICE_OBJECT deviceObject, * state in the instance to indicate the command that started the dump * operation. The state can setup 'ovsMsgReadOp' appropriately. Note * that 'ovsMsgReadOp' is needed only in this function to call into the - * appropraite handler. The handler itself can access the state in the + * appropriate handler. The handler itself can access the state in the * instance. * * In the absence of a dump start, return 0 bytes. @@ -1350,9 +1350,7 @@ OvsSetupDumpStart(POVS_USER_PARAMS_CONTEXT usrParamsCtx) * This operation should be setting up the dump state. If there's any * previous state, clear it up so as to set it up afresh. */ - if (instance->dumpState.ovsMsg != NULL) { - FreeUserDumpState(instance); - } + FreeUserDumpState(instance); return InitUserDumpState(instance, msgIn); } -- 2.20.1