From 356d5d28f2cd45ee1956ee868de6f5d37bb9f7dd Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Wed, 14 Jan 2015 09:10:56 +0800 Subject: [PATCH] Mailbox: Fix return value check in pcc_init() In case of error, the function platform_create_bundle() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/mailbox/pcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 6dbf6fcbdfaf..70576fb707a5 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -393,9 +393,9 @@ static int __init pcc_init(void) pcc_pdev = platform_create_bundle(&pcc_mbox_driver, pcc_mbox_probe, NULL, 0, NULL, 0); - if (!pcc_pdev) { + if (IS_ERR(pcc_pdev)) { pr_err("Err creating PCC platform bundle\n"); - return -ENODEV; + return PTR_ERR(pcc_pdev); } return 0; -- 2.20.1