From 466793cfa4695866c9d91362a6b948f604de7b67 Mon Sep 17 00:00:00 2001 From: Ansis Atteka Date: Mon, 29 Oct 2012 18:12:03 +0200 Subject: [PATCH] netdev-vport: Warn users that pmtud is deprecated This is a complementary patch to the other one I sent out previously. The purpose of it is to make it more obvious that tunnel pmtud is deprecated and will be removed soon. Requested-by: Jesse Gross Signed-off-by: Ansis Atteka --- NEWS | 4 +++- debian/changelog | 3 +++ lib/netdev-vport.c | 4 ++++ utilities/ovs-save | 2 +- vswitchd/vswitch.xml | 3 ++- 5 files changed, 13 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index b4e5bc1ef..6556e60ac 100644 --- a/NEWS +++ b/NEWS @@ -28,7 +28,8 @@ v1.9.0 - xx xxx xxxx are true, but because we do not know of any users for this feature it seems better on balance to remove it. (The ovs-pki-cgi program was not included in distribution packaging.) - - Tunnel Path MTU Discovery default value was set to 'disabled'. + - Tunnel Path MTU Discovery default value was set to 'disabled'. This + feature is deprecated and will be removed soon. - ovsdb-server now enforces the immutability of immutable columns. This was not enforced in earlier versions due to an oversight. - New support for a nonstandard form of GRE that supports a 64-bit key. @@ -39,6 +40,7 @@ v1.9.0 - xx xxx xxxx - The autopath action. - Interface type "null". - Numeric values for reserved ports (see "ovs-ofctl" note above). + - Tunnel Path MTU Discovery. v1.8.0 - xx xxx xxxx diff --git a/debian/changelog b/debian/changelog index bf45202e9..40c491972 100644 --- a/debian/changelog +++ b/debian/changelog @@ -29,6 +29,8 @@ openvswitch (1.9.0-1) unstable; urgency=low are true, but because we do not know of any users for this feature it seems better on balance to remove it. (The ovs-pki-cgi program was not included in distribution packaging.) + - Tunnel Path MTU Discovery default value was set to 'disabled'. This + feature is deprecated and will be removed soon. - ovsdb-server now enforces the immutability of immutable columns. This was not enforced in earlier versions due to an oversight. - New support for a nonstandard form of GRE that supports a 64-bit key. @@ -39,6 +41,7 @@ openvswitch (1.9.0-1) unstable; urgency=low - The autopath action. - Interface type "null". - Numeric values for reserved ports (see "ovs-ofctl" note above). + - Tunnel Path MTU Discovery. -- Open vSwitch team Wed, 24 Oct 2012 16:10:39 -0700 diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 416895963..ee9cb0426 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -648,6 +648,10 @@ parse_tunnel_config(const char *name, const char *type, } } else if (!strcmp(node->key, "pmtud")) { if (!strcmp(node->value, "true")) { + VLOG_WARN_ONCE("%s: The tunnel Path MTU discovery is " + "deprecated and may be removed in February " + "2013. Please email dev@openvswitch.org with " + "concerns.", name); flags |= TNL_F_PMTUD; } } else if (!strcmp(node->key, "header_cache")) { diff --git a/utilities/ovs-save b/utilities/ovs-save index 9ed14ebb3..ee4717c40 100755 --- a/utilities/ovs-save +++ b/utilities/ovs-save @@ -195,7 +195,7 @@ save_datapaths () { # lookups: hit:0 missed:0 lost:0 # flows: 0 # port 0: br1 (internal) - # port 2: gre2886795521 (ipsec_gre: key=flow, pmtud=false, remote_ip=172.17.1.1, tos=inherit) + # port 2: gre2886795521 (ipsec_gre: key=flow, remote_ip=172.17.1.1, tos=inherit) # port 3: gre1 (ipsec_gre: remote_ip=192.168.113.1) # port 14: gre2 (gre: remote_ip=192.168.115.1) # port 15: gre3 (gre64: remote_ip=192.168.116.1) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 0bc4ccdc8..f486d6afd 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -1366,7 +1366,8 @@ of the tunnel headers. Note that this option causes behavior that is typically reserved for routers and therefore is not entirely in compliance with the IEEE 802.1D specification for bridges. Default is - disabled; set to true to enable. + disabled; set to true to enable. This feature is + deprecated and will be removed soon. -- 2.20.1