From b1bbb9795d93676a6e0a965de94e8df7d78b0a0d Mon Sep 17 00:00:00 2001 From: Daniel Kurtz Date: Wed, 5 Sep 2012 16:16:51 +0800 Subject: [PATCH] CHROMIUM: ARM: exynos: no duplicate mask/unmask in eint0_15 chained_irq_enter/exit() already mask&ack/unmask the chained interrupt. There is no need to also explicitly do it in the handler. Signed-off-by: Daniel Kurtz BUG=chrome-os-partner:13488 TEST=Manually verify. TEST=ftrace shows only one call to combiner_{mask,unmask}_irq per call to exynos_irq_eint0_15 Change-Id: Id978cb4574af3ef1c6adccb1453ad2c51049e08b Reviewed-on: https://gerrit.chromium.org/gerrit/32215 Reviewed-by: Doug Anderson Commit-Ready: Daniel Kurtz Reviewed-by: Daniel Kurtz Tested-by: Daniel Kurtz --- arch/arm/mach-exynos/common.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index a2383e682702..99dcc939b572 100644 --- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos/common.c @@ -1088,15 +1088,8 @@ static void exynos_irq_eint0_15(unsigned int irq, struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); - eint_irq = irq_find_mapping(irq_domain, *irq_data); generic_handle_irq(eint_irq); - - chip->irq_unmask(&desc->irq_data); chained_irq_exit(chip, desc); } -- 2.20.1