phy: exynos-mipi-video: avoid uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Wed, 11 May 2016 12:49:53 +0000 (14:49 +0200)
committerKishon Vijay Abraham I <kishon@ti.com>
Mon, 30 May 2016 12:51:37 +0000 (18:21 +0530)
commit06061dc63bff8d609bc8d64f5d3ef59d0a673b25
treecbc288dbbd85454a99626bc0814f68d8fb12c24a
parent1a695a905c18548062509178b98bc91e67510864
phy: exynos-mipi-video: avoid uninitialized variable use

A rework of the exynos-mipi-video driver caused a warning
about the new __set_phy_state function potentially accessing
a variable before its initialization:

drivers/phy/phy-exynos-mipi-video.c: In function '__set_phy_state':
drivers/phy/phy-exynos-mipi-video.c:238:13: error: 'val' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return val & data->resetn_val;
         ~~~~^~~~~~~~~~~~~~~~~~
drivers/phy/phy-exynos-mipi-video.c:235:6: note: 'val' was declared here
  u32 val;

The failure scenario here is the offset passed into a the
stub regmap_read() function that does not modify its output,
however regmap_read() can also fail for other reasons, so
adding error handling (in this case, returning zero from
is_running) seems the best solution.

Note that this warning showed up with the ARM s5pv210_defconfig,
indicating that we most likely want to either enable CONFIG_REGMAP
in that defconfig as well, or disable the phy-exynos-mipi-video
driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 97a3042f7616 ("phy: exynos-mipi-video: Rewrite handling of phy registers")
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-exynos-mipi-video.c