fib_trie: Drop unnecessary calls to leaf_pull_suffix
authorAlexander Duyck <alexander.h.duyck@redhat.com>
Mon, 27 Jul 2015 20:08:06 +0000 (13:08 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Jul 2015 21:29:11 +0000 (14:29 -0700)
commit1513069edcf8dd86cfd8d5daef482b97d6b93df6
treee1a68f3db60e7642afe71a732f213b73d55e0663
parent7a6e0706c09b121d4656b055d9b0494320246f4f
fib_trie: Drop unnecessary calls to leaf_pull_suffix

It was reported that update_suffix was taking a long time on systems where
a large number of leaves were attached to a single node.  As it turns out
fib_table_flush was calling update_suffix for each leaf that didn't have all
of the aliases stripped from it.  As a result, on this large node removing
one leaf would result in us calling update_suffix for every other leaf on
the node.

The fix is to just remove the calls to leaf_pull_suffix since they are
redundant as we already have a call in resize that will go through and
update the suffix length for the node before we exit out of
fib_table_flush or fib_table_flush_external.

Reported-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_trie.c