cpuset: fix a regression in validating config change
authorLi Zefan <lizefan@huawei.com>
Wed, 21 Aug 2013 02:22:28 +0000 (10:22 +0800)
committerTejun Heo <tj@kernel.org>
Wed, 21 Aug 2013 12:40:27 +0000 (08:40 -0400)
commit1c09b195d37fa459844036f429a0f378e70c3db6
treef5a489a926304b07a982ea61a7ea8ebeaf253653
parenta903f0865a190f8778c73df1a810ea6e25e5d7cf
cpuset: fix a regression in validating config change

It's not allowed to clear masks of a cpuset if there're tasks in it,
but it's broken:

  # mkdir /cgroup/sub
  # echo 0 > /cgroup/sub/cpuset.cpus
  # echo 0 > /cgroup/sub/cpuset.mems
  # echo $$ > /cgroup/sub/tasks
  # echo > /cgroup/sub/cpuset.cpus
  (should fail)

This bug was introduced by commit 88fa523bff295f1d60244a54833480b02f775152
("cpuset: allow to move tasks to empty cpusets").

tj: Dropped temp bool variables and nestes the conditionals directly.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cpuset.c