ARM: 7851/1: check for number of arguments in syscall_get/set_arguments()
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Wed, 9 Oct 2013 14:58:29 +0000 (15:58 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 13 Oct 2013 17:54:33 +0000 (18:54 +0100)
commit3c1532df5c1b54b5f6246cdef94eeb73a39fe43a
tree305121d41606b825c069647564d7877faf8d75e3
parentbc41b8724f24b9a27d1dcc6c974b8f686b38d554
ARM: 7851/1: check for number of arguments in syscall_get/set_arguments()

In ftrace_syscall_enter(),
    syscall_get_arguments(..., 0, n, ...)
        if (i == 0) { <handle ORIG_r0> ...; n--;}
        memcpy(..., n * sizeof(args[0]));
If 'number of arguments(n)' is zero and 'argument index(i)' is also zero in
syscall_get_arguments(), none of arguments should be copied by memcpy().
Otherwise 'n--' can be a big positive number and unexpected amount of data
will be copied. Tracing system calls which take no argument, say sync(void),
may hit this case and eventually make the system corrupted.
This patch fixes the issue both in syscall_get_arguments() and
syscall_set_arguments().

Cc: <stable@vger.kernel.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/include/asm/syscall.h