virtio-balloon: do not call blocking ops when !TASK_RUNNING
authorMichael S. Tsirkin <mst@redhat.com>
Tue, 10 Mar 2015 01:25:08 +0000 (11:55 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Tue, 10 Mar 2015 01:26:15 +0000 (11:56 +1030)
commit3d2a3774c1b046f548ebea0391a602fd5685a307
treeb664aba0a08380007cb1ae1b53a743c65957c6bc
parent0fa2a56437d0b7ef5d86eef2778ad3469ca72d5a
virtio-balloon: do not call blocking ops when !TASK_RUNNING

virtio balloon has this code:
        wait_event_interruptible(vb->config_change,
                                 (diff = towards_target(vb)) != 0
                                 || vb->need_stats_update
                                 || kthread_should_stop()
                                 || freezing(current));

Which is a problem because towards_target() call might block after
wait_event_interruptible sets task state to TAST_INTERRUPTIBLE, causing
the task_struct::state collision typical of nesting of sleeping
primitives

See also http://lwn.net/Articles/628628/ or Thomas's
bug report
http://article.gmane.org/gmane.linux.kernel.virtualization/24846
for a fuller explanation.

To fix, rewrite using wait_woken.

Cc: stable@vger.kernel.org
Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/virtio/virtio_balloon.c