task_work: use READ_ONCE/lockless_dereference, avoid pi_lock if !task_works
authorOleg Nesterov <oleg@redhat.com>
Tue, 2 Aug 2016 21:03:44 +0000 (14:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 2 Aug 2016 23:35:02 +0000 (19:35 -0400)
commit61e96496d3c949701a48b908f99f4ed891cd1101
treebf282d3036968de0bfd834914d712b6875fff7e3
parent949bed2f5764435715e3d6dd3ab6dd4dbd890a71
task_work: use READ_ONCE/lockless_dereference, avoid pi_lock if !task_works

Change task_work_cancel() to use lockless_dereference(), this is what
the code really wants but we didn't have this helper when it was
written.

Also add the fast-path task->task_works == NULL check, in the likely
case this task has no pending works and we can avoid
spin_lock(task->pi_lock).

While at it, change other users of ACCESS_ONCE() to use READ_ONCE().

Link: http://lkml.kernel.org/r/20160610150042.GA13868@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Andrea Parri <parri.andrea@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/task_work.c