usb: chipidea: udc: fix NULL ptr dereference in isr_setup_status_phase
authorClemens Gruber <clemens.gruber@pqgruber.com>
Mon, 5 Sep 2016 17:29:58 +0000 (19:29 +0200)
committerPeter Chen <peter.chen@nxp.com>
Fri, 9 Sep 2016 09:19:57 +0000 (17:19 +0800)
commit6f3c4fb6d05e63c9c6d8968302491c3a5457be61
tree26dae4806595cc0b4a62e930a2352cad5cce812a
parentc4e94174983a86c935be1537a73e496b778b0287
usb: chipidea: udc: fix NULL ptr dereference in isr_setup_status_phase

Problems with the signal integrity of the high speed USB data lines or
noise on reference ground lines can cause the i.MX6 USB controller to
violate USB specs and exhibit unexpected behavior.

It was observed that USBi_UI interrupts were triggered first and when
isr_setup_status_phase was called, ci->status was NULL, which lead to a
NULL pointer dereference kernel panic.

This patch fixes the kernel panic, emits a warning once and returns
-EPIPE to halt the device and let the host get stalled.
It also adds a comment to point people, who are experiencing this issue,
to their USB hardware design.

Cc: <stable@vger.kernel.org> #4.1+
Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
drivers/usb/chipidea/udc.c