fq_codel: add batch ability to fq_codel_drop()
authorEric Dumazet <edumazet@google.com>
Sun, 1 May 2016 23:47:26 +0000 (16:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 May 2016 16:47:09 +0000 (12:47 -0400)
commit9d18562a227874289fda8ca5d117d8f503f1dcca
treec00c1688e73773f12f3071998bcf20679695dc8e
parent094e43d50d7e421e9036d72a5a1d93c250cdbf0a
fq_codel: add batch ability to fq_codel_drop()

In presence of inelastic flows and stress, we can call
fq_codel_drop() for every packet entering fq_codel qdisc.

fq_codel_drop() is quite expensive, as it does a linear scan
of 4 KB of memory to find a fat flow.
Once found, it drops the oldest packet of this flow.

Instead of dropping a single packet, try to drop 50% of the backlog
of this fat flow, with a configurable limit of 64 packets per round.

TCA_FQ_CODEL_DROP_BATCH_SIZE is the new attribute to make this
limit configurable.

With this strategy the 4 KB search is amortized to a single cache line
per drop [1], so fq_codel_drop() no longer appears at the top of kernel
profile in presence of few inelastic flows.

[1] Assuming a 64byte cache line, and 1024 buckets

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dave Taht <dave.taht@gmail.com>
Cc: Jonathan Morton <chromatix99@gmail.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Dave Taht
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/pkt_sched.h
net/sched/sch_fq_codel.c