xfs: refactor single extent shift into xfs_bmse_shift_one() helper
authorBrian Foster <bfoster@redhat.com>
Tue, 23 Sep 2014 05:39:04 +0000 (15:39 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 23 Sep 2014 05:39:04 +0000 (15:39 +1000)
commita979bdfea10a61dce0055b4d416d640f4f5f495e
treeef48ae3ce031f6133fa2c9c56d01f6d31fe4d953
parentddb19e3180fa42362a04e86771d758be1de0bb13
xfs: refactor single extent shift into xfs_bmse_shift_one() helper

xfs_bmap_shift_extents() has a variety of conditions and error checks
that make the logic difficult to follow and indent heavy. Refactor the
loop body of this function into a new xfs_bmse_shift_one() helper. This
simplifies the error checks, eliminates index decrement on merge hack by
pushing the index increment down into the helper, and makes the code
more readable by reducing multiple levels of indentation.

This is a code refactor only. The behavior of extent shift and collapse
range is not modified.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/libxfs/xfs_bmap.c