ovl: fix permission checking for setattr
authorMiklos Szeredi <miklos@szeredi.hu>
Fri, 4 Dec 2015 18:18:48 +0000 (19:18 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 6 Dec 2015 17:28:23 +0000 (12:28 -0500)
commitacff81ec2c79492b180fade3c2894425cd35a545
treeda3c7514877f6881b8be76e203614917227be52a
parent31ade3b83e1821da5fbb2f11b5b3d4ab2ec39db8
ovl: fix permission checking for setattr

[Al Viro] The bug is in being too enthusiastic about optimizing ->setattr()
away - instead of "copy verbatim with metadata" + "chmod/chown/utimes"
(with the former being always safe and the latter failing in case of
insufficient permissions) it tries to combine these two.  Note that copyup
itself will have to do ->setattr() anyway; _that_ is where the elevated
capabilities are right.  Having these two ->setattr() (one to set verbatim
copy of metadata, another to do what overlayfs ->setattr() had been asked
to do in the first place) combined is where it breaks.

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/overlayfs/inode.c