storvsc: be more picky about scmnd->sc_data_direction
authorVitaly Kuznetsov <vkuznets@redhat.com>
Thu, 25 Jun 2015 16:12:11 +0000 (18:12 +0200)
committerJames Bottomley <JBottomley@Odin.com>
Wed, 12 Aug 2015 22:55:59 +0000 (15:55 -0700)
commitcb1cf0804fe582f8a626c3cc591cb3127536137c
tree2e9add2e90a00a512c97c262b628d2a74c0a0ee5
parent10978e48ccc1718dce5c2d275b761ab99c593a81
storvsc: be more picky about scmnd->sc_data_direction

Under the 'default' case in scmnd->sc_data_direction we have 3 options:
- DMA_NONE which we handle correctly.
- DMA_BIDIRECTIONAL which is never supposed to be set by SCSI stack.
- Garbage value.

Do WARN() and return -EINVAL in the last two cases. virtio_scsi does
BUG_ON() here but it looks like an overkill.

Reported-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/storvsc_drv.c