net: VRF: Pass original iif to ip_route_input()
authorMark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Wed, 14 Sep 2016 23:40:05 +0000 (11:40 +1200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Sep 2016 08:24:07 +0000 (04:24 -0400)
commitd6f64d725bac20df66b2eacd847fc41d7a1905e0
treeae42b15809831078395b2adc0e64406780b8b026
parent7106a069f45b15e63d14484e72969e64798e641c
net: VRF: Pass original iif to ip_route_input()

The function ip_rcv_finish() calls l3mdev_ip_rcv(). On any VRF except
the global VRF, this replaces skb->dev with the VRF master interface.
When calling ip_route_input_noref() from here, the checks for forwarding
look at this master device instead of the initial ingress interface.
This will allow packets to be routed which normally would be dropped.
For example, an interface that is not assigned an IP address should
drop packets, but because the checking is against the master device, the
packet will be forwarded.

The fix here is to still call l3mdev_ip_rcv(), but remember the initial
net_device. This is passed to the other functions within ip_rcv_finish,
so they still see the original interface.

Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_input.c