dm: set DMF_SUSPENDED* _before_ clearing DMF_NOFLUSH_SUSPENDING
authorMike Snitzer <snitzer@redhat.com>
Tue, 2 Aug 2016 17:07:20 +0000 (13:07 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 2 Aug 2016 20:21:37 +0000 (16:21 -0400)
commiteaf9a7361f47727b166688a9f2096854eef60fbe
tree98d036f8cfcd2f4e060a83264e1a4121829cf93c
parent7d9595d848cdff5c7939f68eec39e0c5d36a1d67
dm: set DMF_SUSPENDED* _before_ clearing DMF_NOFLUSH_SUSPENDING

Otherwise, there is potential for both DMF_SUSPENDED* and
DMF_NOFLUSH_SUSPENDING to not be set during dm_suspend() -- which is
definitely _not_ a valid state.

This fix, in conjuction with "dm rq: fix the starting and stopping of
blk-mq queues", addresses the potential for request-based DM multipath's
__multipath_map() to see !dm_noflush_suspending() during suspend.

Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm.c