drbd: Fix future possible NULL pointer dereference
authorAndreas Gruenbacher <agruen@linbit.com>
Wed, 19 Feb 2014 09:49:07 +0000 (10:49 +0100)
committerJens Axboe <axboe@fb.com>
Fri, 21 Feb 2014 23:42:34 +0000 (15:42 -0800)
commitf597f6b8dfaa033be3b3b755e6c0ab3caee96dcd
tree048a1e13e96fd13adb322009f71bf7ff07de67be
parent2457b6d5ee1a9ff8a3c15ea8eaa5bc195a47d326
drbd: Fix future possible NULL pointer dereference

Right now every resource has exactly one connection. But we are preparing
for dynamic connections. I.e. in the future thre can be resources without
connections.

However smatch points this out as 'variable dereferenced before check',
which is correct.

This issue was introduced in
drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andreas Gruenbacher <agruen@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/drbd/drbd_nl.c