dpctl: Fix jump through wild pointer in "dpctl/help".
authorBen Pfaff <blp@nicira.com>
Sat, 17 Oct 2015 21:24:01 +0000 (14:24 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 4 Nov 2015 01:41:05 +0000 (17:41 -0800)
commit337c452854451ed1b32d414a44c62b78b4a057c9
tree39f378eb7142aba863618eb576a1d9ba51b6d56e
parent3ee7cc6c37c2477295c816fab54d8c6adb8f3003
dpctl: Fix jump through wild pointer in "dpctl/help".

dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure
it passed to the handler, which meant that dpctl_help() could see a nonnull
(indeterminate) 'usage' pointer and jump through it, causes a crash.
This commit fixes the crash by fully initializing the structure.

The dpctl/help command wasn't going to do anything useful anyway, so this
commit also stops registering it.

Reported-by: Murali R <muralirdev@gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-October/019135.html
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
AUTHORS
lib/dpctl.c